Use SAM to calculate power output #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparm
reviewed
Jan 9, 2019
| @@ -1 +1 @@ | |||
| __all__ = ["eia"] | |||
| __all__ = ["EIA"] | |||
There was a problem hiding this comment.
It should be but the module itself is upper case. Do you want to rename the directory and change the various call to the module throughout the code?
There was a problem hiding this comment.
Yes, rename to lower case please.
kasparm
approved these changes
Jan 9, 2019
Merged
rouille
changed the title
jmbott
pushed a commit
to SEL-Columbia/PreREISE
that referenced
this pull request
May 26, 2022
jmbott
pushed a commit
to SEL-Columbia/PreREISE
that referenced
this pull request
May 26, 2022
BainanXia
added a commit
to SEL-Columbia/PreREISE
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is dedicated to the implementation of the solar profiles with SAM. A lot of work has been done on the documentation (README, docstrings across the package) as well. @mlamherr will have to include her changes too (demand profiles v2 -> v3 and other improvements), I believe.